apply change: Fix adding component with non default simple attributes. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding a component with simple attributes, these attributes might have default values that aren't `nil`. Previously, when such a thing occurred it would result in a `MergeError`, because the removed change was assumed to be `nil` since the component was just added, but in practice it would be set to the default value. The solution is to set the removed change value to the default value.
byohay
force-pushed
the
feature/fix-adding-simple-attribute-with-default-value
branch
from
9283ba7
to
75a5efd
Compare
ashdnazg
reviewed
Jun 6, 2022
| @@ -694,6 +698,12 @@ def add_attributes_to_component(component, change, change_path, ignore_keys: []) | |||
| end | |||
| end | |||
|
|
|||
| def simple_attribute_default_value(component, attribute_name) | |||
| component.simple_attributes.find do |attribute| | |||
There was a problem hiding this comment.
This is awful, but it's probably not worth using private API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a component with simple attributes, these attributes might
have default values that aren't
nil. Previously, when such a thingoccurred it would result in a
MergeError, because the removed changewas assumed to be
nilsince the component was just added, but inpractice it would be set to the default value.
The solution is to set the removed change value to the default value.