Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply change: Fix adding component with non default simple attributes. #67

Merged
merged 1 commit into from
Jun 6, 2022
Merged

apply change: Fix adding component with non default simple attributes. #67

merged 1 commit into from
Jun 6, 2022

Commits on Jun 4, 2022

  1. apply change: Fix adding component with non default simple attributes. 

    When adding a component with simple attributes, these attributes might
have default values that aren't `nil`. Previously, when such a thing
occurred it would result in a `MergeError`, because the removed change
was assumed to be `nil` since the component was just added, but in
practice it would be set to the default value.
The solution is to set the removed change value to the default value.
    @byohay
    byohay committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    75a5efd View commit details
    Browse the repository at this point in the history