Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #36

Merged
merged 1 commit into from
May 24, 2024
Merged

Cleanup #36

merged 1 commit into from
May 24, 2024

Conversation

konsumlamm
Copy link
Contributor

These are some improvements from #33 that are worthwhile regardless.

@konsumlamm
Cleanup
ba83fc2 
Extract parts to functions
Rename
Add some comments
`ws_message::ServerMessage` to `ClientResponse`
@konsumlamm konsumlamm merged commit 75e353b into main May 24, 2024
4 checks passed
@konsumlamm konsumlamm deleted the wischmopp branch May 24, 2024 14:50
Comeza pushed a commit that referenced this pull request Jun 2, 2024
@konsumlamm @Comeza
Cleanup (#36)
a4d675a 
Extract parts to functions
Rename
Add some comments
`ws_message::ServerMessage` to `ClientResponse`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Comeza Comeza Comeza approved these changes

@TrueDoctor TrueDoctor Awaiting requested review from TrueDoctor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@konsumlamm @Comeza