Implemented the atom:entry:link relation "via" to credit source feed. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems I’m pointing back to the source site instead of the feed. I misunderstood what the_feed_url did. It worked for enough feeds in my testing that I didn’t notice that this assumption wasn’t correct. I wanted to credit the source feed and not the site. I can’t see an easy way to retrieve the link to the source feed. But crediting the site using the via link relation is not ‘wrong’ so I will leave it as it is for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an description of the relevant standard. http://www.atomenabled.org/developers/syndication/#link
(On a related note: I’ve also added a canonical link relation for the source link in my template.)
The "source" element is also very relevant for the feeds output by Lilina. But I haven’t look into how to acheive that just yet. http://www.atomenabled.org/developers/syndication/#optionalEntryElements