Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and fix issue 74 for Julia version 1.8+ #75

Merged
merged 7 commits into from
Mar 8, 2024
Merged

Test and fix issue 74 for Julia version 1.8+ #75

merged 7 commits into from
Mar 8, 2024

Conversation

LilithHafner
Copy link
Owner

The test is always 10/10 locally, but I don't want false positives.

@LilithHafner LilithHafner changed the title Test and fix issue 74 Test and fix issue 74 for Julia version 1.8+ Mar 8, 2024
@LilithHafner
Copy link
Owner Author

These test failures bring me joy

  Expression: cor(x, times[x]) > 0.99
 Got correct result, please change to @test if no longer broken.

Near monotonicity for evalpoly: Error During Test at /Users/runner/work/Chairmarks.jl/Chairmarks.jl/test/runtests.jl:271
 Unexpected Pass
 Expression: cor(x, times[x]) > 0.99
 Got correct result, please change to @test if no longer broken.

@LilithHafner LilithHafner merged commit 4c24cd0 into main Mar 8, 2024
14 of 15 checks passed
@LilithHafner LilithHafner deleted the lh/fix-74 branch March 8, 2024 16:52
@LilithHafner LilithHafner linked an issue Mar 8, 2024 that may be closed by this pull request
Less accurate answers than BenchmarkTools on some microbenchmarks #74
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
timing results
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Less accurate answers than BenchmarkTools on some microbenchmarks
1 participant
@LilithHafner