-
Notifications
You must be signed in to change notification settings - Fork 986
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
c475c4d
commit 49772b7
Showing
1 changed file
with
25 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49772b7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Menno, getAnswerFromCode now returns a completely different data type (array instead of CActiveRecord) - but it looks like you did not convert the places from where this is called. Response browsing seems to be partially broken now - as example try the survey from http://bugs.limesurvey.org/view.php?id=7112
Can you please have a look at this asap?
49772b7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read something in forum abouth answer code L but don't understand... returned value is only ever used as array so that should not make a difference. Query returns CDbDataReader and that is interator like array . Are you sure about the linked bug? it is about a different subject. Will have a look later today. Probably the 'or die' should be removed in common helper but that could only occur when the answer we are looking for is not in db and that is an error.
49772b7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I mean only the survey from that linked bug. Just acitvate it,answer it once and try to view the responses. You will see an error above the response grid resulting from this. I rolled back until this patch und it works in the revision prior to this so something does not work as it should with this patch.
49772b7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mennodekker : replacing ->query()->readAll(); by ->query(); lauch sameobject than before, no ?
49772b7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick fix: 05cd63d
49772b7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, reverted: 5629add
Had to find beter solution :)
49772b7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok fixed: 87cacbf
feel free to revert if you feel it still is not ok and you want to release
49772b7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mennodekker : CDbDataReader cannot rewind. It is a forward-only reader. Then already reverted :)
Think a new getAnswerFromCode have to use findbypk : but if i don't make error : here primaryKey of answers are array('qid', 'code','language','scale_id'); and not array('qid', 'code'); only
Denis