Skip to content

Commit

Permalink
Dev: Scrutinizer fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
olleharstedt committed Mar 10, 2016
1 parent b0db4c9 commit d0813fc
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions application/core/Survey_Common_Action.php
Original file line number Diff line number Diff line change
Expand Up @@ -257,9 +257,7 @@ protected function _renderWrappedTemplate($sAction = '', $aViewUrls = array(), $
//// TODO : check what is doing exactly this function. (application/helpers/expressions/em_manager_helper.php)
//// If it's about initialiazing global variables, should be removed and parsed in right controllers.
//// But it seems that it's just useless.
LimeExpressionManager::StartProcessingPage(false, Yii::app()->baseUrl,true); // so can click on syntax highlighting to edit questions

$oSurvey = $aData['oSurvey'] = Survey::model()->findByPk($aData['surveyid']);

This comment has been minimized.

Copy link
@Shnoulle

This comment has been minimized.

Copy link
@c-schmitz

c-schmitz Mar 11, 2016

Contributor

Yeah, this commit completely broke administration - and it is out in a release now :-(

This comment has been minimized.

Copy link
@olleharstedt

olleharstedt Mar 11, 2016

Author Collaborator

Sorry! Scrutinizer told me that $oSurvey is not used - but I didn't see that two variables were defined on the same line!

LimeExpressionManager::StartProcessingPage(false, Yii::app()->baseUrl); // so can click on syntax highlighting to edit questions

$this->_titlebar($aData);

Expand Down Expand Up @@ -443,7 +441,6 @@ function _showHeaders($aData)
* @global string $surveyid
* @global string $setfont
* @global string $imageurl
* @param int $surveyid
* @return string $adminmenu
*/
public function _showadminmenu()
Expand All @@ -458,6 +455,7 @@ public function _showadminmenu()
}

// Count active survey
$aData = array();
$aData['dataForConfigMenu']['activesurveyscount'] = $aData['activesurveyscount'] = Survey::model()->count("active = 'Y'");

// Count survey
Expand Down Expand Up @@ -1100,7 +1098,7 @@ function _surveysummary($aData)

if (!$aSurveyInfo['language'])
{
$aData['language'] = getLanguageNameFromCode($currentadminlang, false);
$aData['language'] = getLanguageNameFromCode($baselang, false); // TODO: is $baselang correct here?
}
else
{
Expand Down Expand Up @@ -1208,7 +1206,7 @@ function _browsemenubar($aData)
}
/**
* Load menu bar of user group controller.
* @param int $ugid
* @param array $aData
* @return void
*/
function _userGroupBar($aData)
Expand Down

0 comments on commit d0813fc

Please sign in to comment.