Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better view of readonly advanced setting #1012

Merged
merged 3 commits into from Mar 13, 2018
Merged

Better view of readonly advanced setting #1012

merged 3 commits into from Mar 13, 2018

Conversation

Shnoulle
Copy link
Collaborator

@Shnoulle Shnoulle commented Mar 9, 2018

  • better view of readonly advanced setting
  • replace html by CHtml , seems cleaner
  • The previous one work with input text (only current readonly situation) but we have a lot of other.

@Shnoulle
Copy link
Collaborator Author

Shnoulle commented Mar 9, 2018

Travis issue seems not related

here was 1 failure:

  1. ls\tests\UpdateDbHelperTest::testCompareUpgradeAndFreshInstall
    (Upgraded from db version 258) Comparing field name "name" for column "showdatasecuritynotice" in table "lime_surveys": upgraded value: "showdatasecuritynotice"; fresh install value: null
    Failed asserting that null matches expected 'showdatasecuritynotice'.

@Shnoulle
Merge branch 'master' of https://github.com/LimeSurvey/LimeSurvey.git …
c66dd7d 
…into master_qadvsettings_readonly

* 'master' of https://github.com/LimeSurvey/LimeSurvey.git: (40 commits)
  Dev: Fixed survey saving options
  Fixed issue: Sporadic update error message on login right after upgrade
  Dev: refactor and cleaning of em_manager_helper to reduce double postings
  Dev: Show error message if dbversionumber = currentdbversion in check
  Dev: one more gitignore change
  Fixed issue #13422: Dropdown menu in portuguese internal server error
  Release 3.5.1+180312
  Fixed issue #13247: missing translation in beginner tour
  Dev: removed debug
  Fixed issue: multiple inSurveyView height related problems
  Fixed issue: Cannot install on MSSQL server
  Dev: Set emulatePrepare to correct value if using MSSQL
  Fixed issue #12715: Behavior change for numericalmultiple Slider default value when 0 or null Upgraded PHP version
  Fixed issue: Wrong DSN to MSSQL during install
  Dev: changed gitignore again
  Dev: fixed datatype in updatehelper
  Fixed issue #13467: Untranslated last element in bread crumbs
  Fixed issue #13464: Invalid SQL in "mail_registered_participants" RemoteControl API method
  Fixed issue #13469: 'Check Data integrity' throws Internal server error
  Dev Fixed gitgnore because previous patch was bogus
  ...
@Shnoulle Shnoulle merged commit a875677 into LimeSurvey:master Mar 13, 2018
@Shnoulle Shnoulle deleted the master_qadvsettings_readonly branch May 20, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Shnoulle