Update Question.php #1153
Closed
Update Question.php #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix error query with filter in listquestions: operator does not exist: integer ~~ unknown
Shnoulle
reviewed
Oct 22, 2018
| @@ -1002,7 +1002,7 @@ public function search() | |||
| $criteria2->compare($qid_reference, $this->title, true, 'OR'); | |||
|
|
|||
| if ($this->gid != '') { | |||
| $criteria->compare('groups.gid', $this->gid, true, 'AND'); | |||
| $criteria->compare('groups.gid', $this->gid, false, 'AND'); | |||
There was a problem hiding this comment.
See https://www.yiiframework.com/doc/api/1.1/CDbCriteria#compare-detail this change the partial match then add 1 and 10 and 11 and … if $this->gid is 1, false fixed it
Question : why it's an issue in pgsql ?
There was a problem hiding this comment.
Yes, pgsql want the cast of field for this expression, also we can write the criteria as some lines before
suggestion
$gid_reference = (Yii::app()->db->getDriverName() == 'pgsql' ? ' groups.gid::varchar' : 'groups.gid');
$criteria->compare(gid_reference, $this->gid, true, 'AND');
|
I can see this issue is already fixed, so I would close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix error query in group filter in listquestions view:
error from db pgsql: "operator does not exist: integer ~~ unknown"
Fixed issue # :
New feature # :
Changed feature # :
Dev:
Dev: