14260 mark hidden questions for LS4

[mbischof]

Fixed issue # :
New feature # :
Changed feature # :
Dev:
Dev:

[maziminke]

@lacrioque Can you please check if this looks fine and then merge?
Thanks!

[Shnoulle]

Can you explain the exact feature here ?

Is this related to such feature : #1258 ?

PS : i don't update this feature when i can test Hidden attribute by Expression + hide with css or HTML …

[Shnoulle]

OK, checked : i‘m totally against this commit : only using color/opacity is reall a bad solutiuon.

See my proposal

[Shnoulle]

Must have text : we already add the error text because using only CSS color is bad in 2.05, don't reproduce same issue.

An,d since we have bootsrap : using only bootsrap css/tag is the best solution.

[Shnoulle]

And nned screenshot.

Ps : if you show it elsewhere : i think we must show EM error before hidden or not …

[maziminke]

This is the related bugtracker ticket: https://bugs.limesurvey.org/view.php?id=14260

As outlined before, we simply add a CSS class which allows users to mark hidden questions at their admin theme. Nothing more, nothing less.
We do NOT add any colors or the like so I don't agree to your objections.

[Shnoulle]

Then : i don't really understand the point …

Usage of text and/or data-attribute-hidden and/or information on title is best.

And since css3 is great [data-attribite-hidden]{color: red} do the trick for admin template

[Shnoulle]

If it's for adding CSS/data- in left part : need

1. Question type class/data (i need it …)
2. Hidden attribute
3. Random group attribute (i need it …)
4. Have or not condition/expression
5. …

[lacrioque]

I will close this and reapply it without so many unecessary whitespace changes.
Also data-attributes are applied to the question blocks.

[lacrioque]

See closing message

[Shnoulle]

Yep data-attributes is great :)

I must find a way for random-group for a client now …

[Shnoulle]

@lacrioque : one think more needed maybe : EM error inside question ?
More PHP time consuming maybe … but things it's more needed than other one.