Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #15684: When reloading decimal value with 0 with MSSQL : 0 disappear #1360

Merged
merged 1 commit into from Jan 9, 2020

Conversation

Shnoulle
Copy link
Collaborator

@Shnoulle Shnoulle commented Jan 8, 2020

Fixed issue #15685: Issue when exporting decimal value in MSSQL
Dev: check if value start by . before removing last 0 and last dot
Dev: add 0 is start by .
Dev: Maybe can check with regexp, but use $string[0] seems the speediest solution ?
Dev: doing it for Survey doing , export, response browse and data edit
Dev: don't update ExpressionManager

…0 disappear

Fixed issue #15685: Issue when exporting decimal value in MSSQL
Dev: check if value start by . before removing last 0 and last dot
Dev: add 0 is start by .
Dev: Maybe can check with regexp, but use $string[0] seems the speediest solution ?
Dev: doing it for Survey doing , export, response browse and data edit
Dev: don't update ExpressionManager
@Shnoulle
Copy link
Collaborator Author

Shnoulle commented Jan 8, 2020

In previous commit : error in ExpressionManager must be

            if($arg1[0][0]  === ".") {
                $arg1[0]  = "0".$arg1;
            }
            if (strpos($arg1[0] , ".") !== false) {
                $arg1[0]  = rtrim(rtrim($arg1, "0"), ".");
            }

But since : i'm unsure we need it in Expression manager : i didn't update EM

@olleharstedt
Copy link
Contributor

OK, will test.

@olleharstedt olleharstedt merged commit a4e8900 into LimeSurvey:master Jan 9, 2020
@Shnoulle
Copy link
Collaborator Author

Shnoulle commented Jan 9, 2020

I just add the “fix” where i'm sure it's needed :)

Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants