Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #15733: Survey administrator can receive invalid mail about error #1371

Merged
merged 2 commits into from Jan 20, 2020

Conversation

Shnoulle
Copy link
Collaborator

Dev: PDO system ?
Dev: updateByPk return updated answer, if answer are not updated : return 0

…ut error

Dev: PDO system ?
Dev: updateByPk return updated answer, if answer are not updated : return 0
@olleharstedt
Copy link
Contributor

Will test

@Shnoulle
Copy link
Collaborator Author

Shnoulle commented Jan 20, 2020

@olleharstedt : seems more (maybe) a workaround ?

I have when reload difference with page : 1 !== '1' but 1 == '1'

Maybe : try to update ONLY if needed ? I mean : check if there are difference before try to update ?
What is the speediest : light SQL + PHP check or PHP check + light SQL ?

@olleharstedt
Copy link
Contributor

Denis, please write more detailed instructions on how to reproduce. I can't follow your instructions in the bug ticket. https://bugs.limesurvey.org/view.php?id=15733

@olleharstedt olleharstedt merged commit 896885a into LimeSurvey:3.x-LTS Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants