Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #16166: Survey taking/editing uploaded pictures not showing up #1408

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

tgurr
Copy link
Contributor

@tgurr tgurr commented Apr 21, 2020

Allow .htaccess to also work with apache 2.4 syntax.

@tgurr tgurr changed the title Fixes issue #16166: Survey taking/editing uploaded pictures not showi… Fixed issue #16166: Survey taking/editing uploaded pictures not showing up Apr 21, 2020
@olleharstedt
Copy link
Collaborator

@Shnoulle Can you review, please?

@Shnoulle
Copy link
Collaborator

I don't have apache multiple version …

@Shnoulle
Copy link
Collaborator

(and currently use nginx …) check to have a apache 2.2 and a 2.4 …

@Shnoulle
Copy link
Collaborator

This one seems a hack : https://stackoverflow.com/a/15081790/2239406
Maybe add https://stackoverflow.com/a/20135157/2239406 before

😕

@Shnoulle
Copy link
Collaborator

Let apache 2.2 compatibibility broke :) OK for this @olleharstedt

See https://github.com/LimeSurvey/LimeSurvey/#minimal

@Shnoulle
Copy link
Collaborator

PS

<FilesMatch "^fu_[a-z0-9]*$">
    Require all denied
</FilesMatch>

@Shnoulle
Copy link
Collaborator

For 3LTS too (?)

…ng up

Allow .htaccess to also work with apache 2.4 syntax.
@tgurr
Copy link
Contributor Author

tgurr commented Apr 21, 2020

I've updated the commit to include your suggestions about also including mod_version.

@Shnoulle
Copy link
Collaborator

@olleharstedt : maybe this one for 3LTS but for 4.X : don't care about apache version ?

You're idea ?

@tgurr great job ! Thank you :)

@olleharstedt
Copy link
Collaborator

ping @c-schmitz

@olleharstedt olleharstedt merged commit fa4022f into LimeSurvey:master Apr 22, 2020
@olleharstedt
Copy link
Collaborator

Thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants