Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #15980: No results shown for selected date questions at statistics #1553

Merged
merged 1 commit into from Aug 25, 2020
Merged

Fixed issue #15980: No results shown for selected date questions at statistics #1553

merged 1 commit into from Aug 25, 2020

Conversation

gabrieljenik
Copy link
Collaborator

  • Date/Time responses are treated as "Answer" when the value is not null, and "No answer" when it's null.
  • Equation questions are handled as text. It seems they always have a value, so "Not displayed" may always be 0.
  • Condition had to be updated as to work with dates. It may have an impact on some DB engine (not sure).

@gabrieljenik
Fixed issue #15980: No results shown for selected date questions at s…
90810b8 
…tatistics

- Date/Time responses are treated as "Answer" when the value is not null, and "No answer" when it's null.
- Equation questions are handled as text. It seems they always have a value, so "Not displayed" may always be 0.
- Condition had to be updated as to work with dates. It may have an impact on some DB engine (not sure).
@sushmanadendlals
Copy link

Working as expected. Please refer Mantis for more details

@sushmanadendlals sushmanadendlals added the Tested OK This PR has been tested by QA and works as expected label Aug 20, 2020
@olleharstedt
Copy link
Collaborator

olleharstedt commented Aug 20, 2020 •
edited

What about public statistics? IIRC, it's a copy-paste of admin statistics and needs to be updated independently.

@olleharstedt olleharstedt added the Feedback Waiting for feedback from PR author label Aug 20, 2020
@gabrieljenik
Copy link
Collaborator Author

gabrieljenik commented Aug 20, 2020 •
edited

hmm not sure.. Will review.
Nice catch

@olleharstedt
Copy link
Collaborator

Thanks!

gabrieljenik
gabrieljenik commented Aug 24, 2020
View reviewed changes
Copy link
Collaborator Author

@gabrieljenik gabrieljenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I have checked and text questions don't have a "show in oublic stats" attribute.
Date neither. I guess that is fine.

application/helpers/admin/statistics_helper.php Show resolved Hide resolved
@olleharstedt olleharstedt added Needs update by author and removed Feedback Waiting for feedback from PR author labels Aug 25, 2020
@olleharstedt olleharstedt merged commit 460a012 into LimeSurvey:3.x-LTS Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleharstedt olleharstedt olleharstedt left review comments

Assignees
No one assigned
Labels
Needs update by author Tested OK This PR has been tested by QA and works as expected
Projects
None yet
Milestone
No milestone
3 participants
@gabrieljenik @sushmanadendlals @olleharstedt