Fixed issue #16565: Transfer surveys window to be displayed to ask to transfer surveys to other users while deleting the survey owner #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… transfer surveys to other users while deleting the survey owner Add transfer to screen, shown after confirmation modal
Shnoulle
reviewed
Aug 26, 2020
| ); | ||
| } | ||
| } else { | ||
| // If $transferTo is not null, transfer the surveys |
There was a problem hiding this comment.
If $transferTo is not null but false or empty ? It's a dropdown to select it ?
There was a problem hiding this comment.
Fixed it. now checks for empty before.
Yes, it is a dropdown to select it. That's on the view.
… transfer surveys to other users while deleting the survey owner Code review
eddylackmann
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add transfer to screen, shown after confirmation modal