Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default folder for getFileList(); to "global" #1622

Merged
merged 1 commit into from Oct 19, 2020

Conversation

eliasmagn
Copy link
Contributor

Set default folder for getFileList();
Could be fixed via url generation as well...
https://bugs.limesurvey.org/view.php?id=16130
Fixed issue #16130

Set default folder for
 getFileList
could be fixed via url generation as well
@Shnoulle
Copy link
Collaborator

I like it, but i thhin there are an issue about send an empty folder : when it's done ?

On the issue «everytime i click on "filemanager"» filemanager msut be set according to current survey in general (with some exception : if not : it's an issue :)

@eliasmagn
Copy link
Contributor Author

Just click filemanager in configuration tab. no folder is submitted. Was talking about url/uri generation. I dont know which folder you want to show when opening the filemanager so i choosed a default one. Isnt it better to prevent faults coming from gui, i think about fuzzing. But yes, would be nicer to say something like: if folder not found send exception and set to default folder.
I dont kow if i understand you correctly ;-)

@Shnoulle
Copy link
Collaborator

Have my answer : https://bugs.limesurvey.org/view.php?id=16130#c60185

Thanks :)

Just

        if (empty($folder)) {
            $folder = 'global';
        }

maybe

@cdorin93 cdorin93 added the Tested OK This PR has been tested by QA and works as expected label Oct 19, 2020
@eddylackmann eddylackmann merged commit e52429a into LimeSurvey:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tested OK This PR has been tested by QA and works as expected
Projects
None yet
4 participants