Fixed #08838: The "Access" filter not working if language is not English #178
Conversation
| <option value='Open'><?php $clang->eT("Open") ?></option> | ||
| <option value='Closed'><?php $clang->eT("Closed") ?></option> | ||
| <option value='<?php $clang->eT("Open","js") ?>'><?php $clang->eT("Open") ?></option> | ||
| <option value='<?php $clang->eT("Closed","js") ?>'><?php $clang->eT("Closed") ?></option> | ||
| </select> |
There was a problem hiding this comment.
Hi Thibault,
Quoting the value as JS value causes problems as it is no JS where the value is placed, the standard eT call quotes as HTML which is already fine.
However in the case where the option text and value are the same you can just leave out the value and the option text will be automatically used as value.
There was a problem hiding this comment.
Carsten,
Are you sure the html formatting will encode single-quote ? it was not the case in the past, but I may have missed something.
Anyway you're right, the best option is to replace
option value='eT("Open","js") ?>'>eT("Open") ?></option
by
option>eT("Open") ?></option
I will update the patch
…ly works in English
|
Here is the new patch... I'm using this bug to try to figure out how to use git.... ;-) |
Fixed #08838: The "Access" filter not working if language is not English
|
Hehe, sure, looks fine- thank you! |
No description provided.