Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #17787: open_base_dir + debug can throw error when load s… #2175

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

Shnoulle
Copy link
Collaborator

@Shnoulle Shnoulle commented Dec 8, 2021

Fixed issue #17787: open_base_dir + debug can throw error when load some question type.
Dev: try to load any files in any directory are always an error

…ome question type.

Dev: try to load any files in any directory are always an error
@Shnoulle
Copy link
Collaborator Author

@olleharstedt see cb8043f

I don't understand here this can never work except for core question theme …

  1. This don't take application/view/surveys/questions theme
  2. directory for uploaded theme is broken : always (here). since it's not related to rootdir.

Maybe we need to remove whole system if it's unused ?

@olleharstedt
Copy link
Collaborator

olleharstedt commented Dec 10, 2021

Hm, can never work, but does it work? o0

What I can see, it's using rootdir. But you mean it shouldn't?

@olleharstedt
Copy link
Collaborator

Can you write testing instructions for this commit, please?

@Shnoulle
Copy link
Collaborator Author

  1. Set open_base_dir to /var/:/tmp/:/home/ for example
  2. Activate debug mode
  3. Import included survey
  4. preview question

https://bugs.limesurvey.org/view.php?id=17787

@Shnoulle
Copy link
Collaborator Author

What I can see, it's using rootdir. But you mean it shouldn't?

  1. $sUserQTemplateRootDir = Yii::app()->getConfig("userquestionthemerootdir");
  2. $config['userquestionthemerootdir'] = "upload".DIRECTORY_SEPARATOR.$config['customquestionthemedir']; // The directory containing the user's question themes.

no rootdir …

Just put a log or tracevar at

@c-schmitz c-schmitz merged commit 9c30e88 into LimeSurvey:master Feb 22, 2022
@c-schmitz
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants