Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #17751: Date stamped throw php notice when data edit and debug #2188

Merged
merged 3 commits into from Jan 24, 2022
Merged

Fixed issue #17751: Date stamped throw php notice when data edit and debug #2188

merged 3 commits into from Jan 24, 2022

Conversation

Shnoulle
Copy link
Collaborator

No description provided.

@Shnoulle
Copy link
Collaborator Author

  1. Move to boostrap widget with current user date settings like Survey settings and token edit
  2. Add required attribute
  3. Set a default value in all condition

@Shnoulle Shnoulle marked this pull request as draft December 21, 2021 17:36
@Shnoulle Shnoulle marked this pull request as ready for review December 21, 2021 17:51
gabrieljenik
gabrieljenik reviewed Jan 14, 2022
View reviewed changes
Copy link
Collaborator

@gabrieljenik gabrieljenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK. Seems similar to the one pushed for v5, right?
Not tested.

@gabrieljenik gabrieljenik self-requested a review January 14, 2022 14:57
@Shnoulle
Copy link
Collaborator Author

Code OK. Seems similar to the one pushed for v5, right? Not tested.

Yes : near same fix

@glimz glimz merged commit e4f2fff into LimeSurvey:3.x-LTS Jan 24, 2022
luismontalba pushed a commit to luismontalba/LimeSurvey that referenced this pull request Apr 7, 2022
@Shnoulle @luismontalba
Fixed issue #17751: Date stamped throw php notice when data edit and …
fcd138e 
…debug (LimeSurvey#2188)

* Fixed issue #17751: Date stamped throw php notice when data edit and debug

* Dev: Fix we need a value in all condition .

* Dev: CI happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieljenik gabrieljenik gabrieljenik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Shnoulle @gabrieljenik @glimz