Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #17869: User list in Survey group permission management is unclear #2227

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Fixed issue #17869: User list in Survey group permission management is unclear #2227

merged 2 commits into from
Apr 25, 2022

Conversation

Shnoulle
Copy link
Collaborator

@Shnoulle Shnoulle commented Feb 4, 2022

Dev: add full_name in parenthesis
Dev: create a getUserDescription to be used elsewhere

@Shnoulle
Fixed issue #17869: User list in Survey group permission management i…
41eb632 
…s unclear

Dev: add full_name in parenthesis
Dev: create a getUserDescription to be used elsewhere
gabrieljenik
gabrieljenik approved these changes Feb 21, 2022
View reviewed changes
Copy link
Collaborator

@gabrieljenik gabrieljenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK.
Not Tested.

I usually use method name getDisplayName.

getUserDescription doesn't sound like a good choice to me.
The word User is needed?
Is the word Description a good description for method?

@Shnoulle
Copy link
Collaborator Author

I usually use method name getDisplayName.

👍 seems better.

Let me fix.

@glimz glimz added Tested OK This PR has been tested by QA and works as expected and removed Needs code review Needs testing labels Apr 25, 2022
@glimz glimz merged commit 813de93 into LimeSurvey:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieljenik gabrieljenik Awaiting requested review from gabrieljenik

Assignees
No one assigned
Labels
Tested OK This PR has been tested by QA and works as expected
Projects
None yet
Milestone
No milestone
3 participants
@Shnoulle @gabrieljenik @glimz