Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #12105: Scroll bar partially broken at browse response screen #2262

Conversation

gabrieljenik
Copy link
Collaborator

No description provided.

@Shnoulle
Copy link
Collaborator

It's better, but it's not a total fix right ?

@gabrieljenik
Copy link
Collaborator Author

Well, what would you do?

@Shnoulle
Copy link
Collaborator

see phpMyAdmin for example, or 2.6lts (but need fixed header) : https://bugs.limesurvey.org/view.php?id=12105#c68017

The windows scroll are used directly : it's really an improvment.

@c-schmitz
Copy link
Contributor

c-schmitz commented Feb 22, 2022

The listpager is moving with it -. that is because the name changed.
replace in listresponse.js

    var $elListPager = $('#ListPager');

with

    var $elListPager = $('#reponsesListPager');

@c-schmitz c-schmitz added the Test failed Someone tested the PR and it did not work as expected. Please check out the comments. label Feb 22, 2022
@Shnoulle
Copy link
Collaborator

Or : https://demo.sondages.pro/plugins/direct?plugin=responseListAndManage&sid=526665

(i need to add the fixed header too)

…sponse screen

- Prevent pager from moving when scrolling
- Fix top scroller not working when loaded by pjax
@c-schmitz c-schmitz added Tested OK This PR has been tested by QA and works as expected and removed Test failed Someone tested the PR and it did not work as expected. Please check out the comments. labels Feb 22, 2022
@c-schmitz c-schmitz changed the title Fixed issue #12105: Scroll bar very uncomfortable to use at browse response screen Fixed issue #12105: Scroll bar partiall broken at browse response screen Feb 22, 2022
@c-schmitz c-schmitz changed the title Fixed issue #12105: Scroll bar partiall broken at browse response screen Fixed issue #12105: Scroll bar partially broken at browse response screen Feb 22, 2022
@c-schmitz c-schmitz merged commit def0081 into LimeSurvey:master Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tested OK This PR has been tested by QA and works as expected
Projects
None yet
4 participants