Fix complete index bugs #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SurveyRunTime is really to redo .... Have the fix for changelang too. Some control and update pull request tomorrow. |
Shnoulle
force-pushed
the
master_indexfixes
branch
from
3560a81
to
9a7d0ba
Compare
…stions Fixed issue #09285: Index complet + mandatory question :undefined notice Fixed issue #09198: complete group's navigation can stop before clicked group Fixed issue #08806: questionindex to 2 allow invalid survey submitted Dev: use $force in _validateGroup and _validateQuestion Dev: this allow save value in DB for equation and some other, but never return error. Dev: update EM, then need testing
|
New complete fix |
| $moveResult = LimeExpressionManager::JumpTo($moveResult['seq'], false, false, false);// no preview, no save data and NO force | ||
| if(!$moveResult['mandViolation'] && !$moveResult['valid'] && !$moveResult['invalidSQs']) | ||
| $moveResult['finished'] = true; | ||
| } | ||
| if ($moveResult['finished'] == true) |
There was a problem hiding this comment.
This part for http://bugs.limesurvey.org/view.php?id=8806
Dev: Adding $_SESSION[$LEM->sessid][$answer]=null in _validateQuestion , this ensure using $_SESSION[$LEM->sessid][$answer] Dev: then remove the quick fix at qanda_helper only for $ia[1] (without sub question) Dev: remove global $notanswered at each do_ function, get it by GetLastMoveResult
Shnoulle
added a commit
that referenced
this pull request
Nov 13, 2014
Dev: Fix complete index bugs and some other jumpTo bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't find a way to broke survey with index. But maybe some other test to do ( reload with token, reload with saved ....).
Only JumpTo with force was impacted