Fixed issue #17862: Invalid url in admin (usage of HTTP_HOST)

[gabrieljenik]

Compiling of JS is pending

[Shnoulle]

Strangely : «Add question» is OK but not «add group»

?

[gabrieljenik]

Strangely : «Add question» is OK but not «add group»

?

Sorry, don't understand.
What do you mean?

[Shnoulle]

report : Go to manage admin survey :

1. Can create survey, can edit global settings a lot os OK
2. Add button question in structure goes to limesurvey.intra
3. Global survey settings tab goes all to limesurvey.intra

In structure : Add question is broken , not add group (i made an error in my report)

BUT : i can not reproduce today … on my local nginx …

[c-schmitz]

Code is okay, but CI is not green

[gabrieljenik]

Compiling of JS is pending. I wasn't able to do it. Got errors all time. Asked @olleharstedt for help :)

[olleharstedt]

So it's finally happened. We need to apply a bug fix in adminsidepanel and the build system is FUBAR...

[olleharstedt]

I think Jessica tried to update to Vue 3, but you probably have to downgrade it to Vue 2 again to easily apply a new fix.

[gabrieljenik]

I think Jessica tried to update to Vue 3, but you probably have to downgrade it to Vue 2 again to easily apply a new fix.

I am sorry, we were not able to make it work yet.
Someone want to take it over?

[olleharstedt]

Jessica is back next week, maybe we'll assign it to her then. Or it will have to be a team effort.

Also, death to dependabot.

[olleharstedt]

I moved the task to our internal Zoho project, we'll try to solve it.

[naiteon]

@gabrieljenik side menu has been fixed. If you find any problems reach out to me please.

[gabrieljenik]

@naiteon Thanks! What was it?
What are the next steps then? Should we merge master in here and recompile?

[olleharstedt]

Sorry, still broken. False alarm. :(

[gabrieljenik]

@naiteon Thanks! What was it?
What are the next steps then? Should we merge master in here and recompile?

[naiteon]

@gabrieljenik Hey Gabriel! I think you should stash your changes, rebase your branch against master, then apply the stashed changes and proceed with the PR.

[naiteon]

@gabrieljenik As for compiling the adminsidepanel, there is no need for recompiling it because the distribution files are included in the repo.

[olleharstedt]

@gabrieljenik As for compiling the adminsidepanel, there is no need for recompiling it because the distribution files are included in the repo.

This fix changes the adminsidepanel src files, that's why they need to be recompiled.

[gabrieljenik]

Ready for re review!

[gabrieljenik]

I think this can be merged. Seems tested and also reviewed? Please someone elese confirm it. Thanks

[Shnoulle]

I think this can be merged. Seems tested and also reviewed? Please someone elese confirm it. Thanks

I don't have the exact process for merging ;) .
Maybe the reviewer can merge ?