Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #17963: Numbers on text question does not detect blanks #2305

Merged
merged 3 commits into from
Mar 28, 2022

Conversation

Shnoulle
Copy link
Collaborator

Dev: Number() remove white space then check if not update string

@glimz glimz added Tested OK This PR has been tested by QA and works as expected Needs code review labels Mar 21, 2022
@glimz glimz requested a review from gabrieljenik March 21, 2022 11:12
@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell E 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@olleharstedt olleharstedt merged commit 4a18d7b into LimeSurvey:3.x-LTS Mar 28, 2022
@olleharstedt
Copy link
Collaborator

Thanks!

luismontalba pushed a commit to luismontalba/LimeSurvey that referenced this pull request Apr 7, 2022
…imeSurvey#2305)

Dev: Number() remove white space then check if not update string
Dev: comment about locutus and rename var
Dev: remove unrelated fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs code review Tested OK This PR has been tested by QA and works as expected
Projects
None yet
4 participants