Fixed issue #18184: cpd_importParticipants with encryption turned on, fails to save the participant encrypted in CPDB, causing 500 error to CPDB #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fails to save the participant encrypted in CPDB, causing 500 error to CPDB
Shnoulle
approved these changes
Jun 15, 2022
There was a problem hiding this comment.
Seems OK,
But need big testing in my opinion …
related pull request : https://github.com/LimeSurvey/LimeSurvey/pull/2149/files
Shnoulle
added
Code review done
|
@olleharstedt As this seems to require lot of testing, should we push to develop? |
…ryption-turned-on,-fails-to-save-the-participant-encrypted-in-CPDB,-causing-500-error-to-CPDB
|
Will be creating a test for this. |
…ned on, fails to save the participant encrypted in CPDB Unit tests for encrypted attributes added.
…d-on,-fails-to-save-the-participant-encrypted-in-CPDB,-causing-500-error-to-CPDB' of https://github.com/LimeSurvey/LimeSurvey into bug/18184--cpd_importParticipants-with-encryption-turned-on,-fails-to-save-the-participant-encrypted-in-CPDB,-causing-500-error-to-CPDB
|
Automatic test added. |
Shnoulle
approved these changes
Mar 2, 2023
This is fixed now? Master is ok? |
This PR holds the fix and also an automatic test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.