Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #18239: "Theme options for this survey group" gridview filter not working #2511

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Fixed issue #18239: "Theme options for this survey group" gridview filter not working #2511

merged 1 commit into from
Jul 15, 2022

Conversation

gabrieljenik
Copy link
Collaborator

No description provided.

Shnoulle
Shnoulle approved these changes Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@Shnoulle Shnoulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the commit : can i approve ?

@gabrieljenik
Copy link
Collaborator Author

if the code structure looks ok, I would say yes.
Someone will test it after.

@Shnoulle
Copy link
Collaborator

Shnoulle approved these changes 23 minutes ago

:)

@Shnoulle Shnoulle added Code review done Version checked for code issue without testing and removed Needs code review labels Jul 13, 2022
@gabrieljenik gabrieljenik added Tested OK This PR has been tested by QA and works as expected and removed Needs testing labels Jul 15, 2022
@gabrieljenik gabrieljenik merged commit 34499f9 into LimeSurvey:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shnoulle Shnoulle Shnoulle approved these changes

Assignees
No one assigned
Labels
Code review done Version checked for code issue without testing minor impact Minor impact update / enhancement Tested OK This PR has been tested by QA and works as expected
Projects
None yet
Milestone
No milestone
3 participants
@gabrieljenik @Shnoulle @encuestabizdevgit