Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #17488: Cannot view survey after updating to version 3.279 with custom twig extension (breaks survey) #2518

Merged
merged 1 commit into from Aug 2, 2022
Merged

Fixed issue #17488: Cannot view survey after updating to version 3.279 with custom twig extension (breaks survey) #2518

merged 1 commit into from Aug 2, 2022

Conversation

gabrieljenik
Copy link
Collaborator

@gabrieljenik gabrieljenik commented Jul 18, 2022 •
edited

Same fix as for LTS, applied to master

@encuestabizdevgit
Fixed issue #17488: Cannot view survey after updating to version 3.27…
5d8cc1e 
….9 with custom twig extension (breaks survey)
@gabrieljenik gabrieljenik added Tested OK This PR has been tested by QA and works as expected and removed Needs testing labels Jul 27, 2022
@gabrieljenik
Copy link
Collaborator Author

Tested by @tpartner .
@Shnoulle Can I ask for your reviewal?

Shnoulle
Shnoulle reviewed Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@Shnoulle Shnoulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Need to sanitize $extName
  2. addUserExtensions must be public ?

application/core/LSETwigViewRenderer.php Show resolved Hide resolved
@Shnoulle Shnoulle added Discussion ongoing Code review done Version checked for code issue without testing and removed Needs code review labels Jul 27, 2022
@olleharstedt olleharstedt merged commit 0d1f8bd into LimeSurvey:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleharstedt olleharstedt olleharstedt left review comments

@Shnoulle Shnoulle Shnoulle approved these changes

Assignees
No one assigned
Labels
Code review done Version checked for code issue without testing Discussion ongoing Technical Technical update / enhancement Tested OK This PR has been tested by QA and works as expected
Projects
None yet
Milestone
No milestone
4 participants
@gabrieljenik @olleharstedt @Shnoulle @encuestabizdevgit