Fixed issue #18268: Unable to get any page debug set an set_time_limit disable #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t disable Dev: just silence action and log it as error.
gabrieljenik
added
Needs code review
Needs testing
Technical
gabrieljenik
approved these changes
Sep 30, 2022
|
Maybe a helper function like safe_ini_set could help? |
|
We use only ini_set here. Unsure it's needed |
gabrieljenik
added
Code review done
|
@Shnoulle how can I test this? Is this still relevant? |
You need to disable function set_time_limit in PHP You can do it in your local php.ini |
tiborpacalat
added
Tested OK
|
Oh ? This need an update for 8.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev: just silence action and log it as error.