Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #18286: Filter by group name in Group List, does not work #2576

Merged
merged 1 commit into from Aug 26, 2022
Merged

Fixed issue #18286: Filter by group name in Group List, does not work #2576

merged 1 commit into from Aug 26, 2022

Conversation

gabrieljenik
Copy link
Collaborator

No description provided.

@gabrieljenik gabrieljenik added Tested OK This PR has been tested by QA and works as expected minor impact Minor impact update / enhancement and removed Needs testing labels Aug 24, 2022
Shnoulle
Shnoulle requested changes Aug 25, 2022
View reviewed changes
Copy link
Collaborator

@Shnoulle Shnoulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

micro update

maybe (unneded)

$QuestionGroupFilter = App()->getRequest()->get('QuestionGroup'); 
foreach($QuestionGroupFilter as $attribute->value) {

application/controllers/QuestionGroupsAdministrationController.php Show resolved Hide resolved
@olleharstedt olleharstedt merged commit 57c24de into LimeSurvey:master Aug 26, 2022
@olleharstedt
Copy link
Collaborator

Will merge for now so we're making some progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shnoulle Shnoulle Shnoulle requested changes

@olleharstedt olleharstedt Awaiting requested review from olleharstedt

Assignees
No one assigned
Labels
minor impact Minor impact update / enhancement Needs code review Tested OK This PR has been tested by QA and works as expected
Projects
None yet
Milestone
No milestone
4 participants
@gabrieljenik @olleharstedt @Shnoulle @encuestabizdevgit