Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #17870: Default value with line feed broke Expression Script #2605

Merged

Conversation

Shnoulle
Copy link
Collaborator

Dev: json_encode since it a JS var

@Shnoulle Shnoulle added Needs code review Needs testing minor impact Minor impact update / enhancement labels Sep 15, 2022
@Shnoulle Shnoulle changed the title Fixed issue #18355: User can give more permission to any user Fixed issue #17870: Default value with line feed broke Expression Script Sep 16, 2022
@Shnoulle
Copy link
Collaborator Author

Oups … fix the title

Copy link
Collaborator

@gabrieljenik gabrieljenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense.
The encoding which was done previously by a str_replace now is done by json_encode.
Haven't tested it

@Shnoulle
Copy link
Collaborator Author

Merged in master : #2604

@kevin-foster-uk kevin-foster-uk added the Tested OK This PR has been tested by QA and works as expected label Sep 19, 2022
@kevin-foster-uk kevin-foster-uk merged commit c26948d into LimeSurvey:3.x-LTS Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor impact Minor impact update / enhancement Tested OK This PR has been tested by QA and works as expected
Projects
None yet
4 participants