Dev: Allow beforeEmail events to update core replacement #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev: sample : EXPIRY on user language, MESSAGE from user in place of SURVEYDESCRIPTION Dev: …
|
No impact : no core impact, only external Plugin more easy to write. |
gabrieljenik
approved these changes
Sep 21, 2022
gabrieljenik
added
Code review done
|
Label No impact is right here ? Or low impact ? |
|
Should be in dev tho? Since it's not a bug fix? |
|
Then : new plugin can not use it … and need to find a workaround. It's one of the reason why i didn't try to improve LimeSurveyAPI : time to be merged : i already publish the plugin Here : it's really a light update, then i think its good on master. |
|
Fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev: sample : EXPIRY on user language, MESSAGE from user in place of SURVEYDESCRIPTION
Dev: …