Fixed issue #18343: Problem with interpreting double slash in URL (IIS) #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev: use PHP to construct the url Dev: check if non empty before adding it
Shnoulle
added
Needs code review
Needs testing
minor impact
gabrieljenik
approved these changes
Sep 29, 2022
|
Same than 3LTS except the contdir (unsure it's used) |
|
Reporter test the commit on 3LTS : fixed the popup editor but have another issue with Placeholder for example. OK to set it as tested ? |
…iels url Dev: validity not checked in 5.X
Dev: needed only for GIT update
Shnoulle
added
Code review done
|
PHPCS on Update_496.php : not related to this commit |
|
Need to check and fix https://bugs.limesurvey.org/view.php?id=18811 |
Shnoulle
added
Needs update by author
and removed
minor impact
|
I redo a simple fix … |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev: use PHP to construct the url
Dev: check if non empty before adding it