Fixed issue #18413: Cannot authenticate with LDAP when using PHP 8.1

[Dennis1993]

After upgrading to PHP 8.1 the login via LDAP isn't possible.

Error message: Cannot use object of type LDAP\Connection as array

This is a fix for it.

Fixed issue #18413 (https://bugs.limesurvey.org/view.php?id=18413)

[Shnoulle]

I think there are issue here : $ldapconn is an array in case of error.

You just avoid the situation here ?

Maybe : if(is_array()) ?

I don't understand why is_resource didn't work here ?

Can you send the whole report on mantis please ?

[Shnoulle]

Can return array or ressource

https://github.com/Dennis1993/LimeSurvey/blob/91006af1e59f8338726dab68cdb8da2915a6372e/application/core/plugins/AuthLDAP/AuthLDAP.php#L340
https://github.com/Dennis1993/LimeSurvey/blob/91006af1e59f8338726dab68cdb8da2915a6372e/application/core/plugins/AuthLDAP/AuthLDAP.php#L351
https://github.com/Dennis1993/LimeSurvey/blob/91006af1e59f8338726dab68cdb8da2915a6372e/application/core/plugins/AuthLDAP/AuthLDAP.php#L361

[Dennis1993]

I found this on Google: https://php.watch/versions/8.1/LDAP-resource @Shnoulle

[Shnoulle]

I found this on Google: https://php.watch/versions/8.1/LDAP-resource @Shnoulle

Yes, but LimeSurvey can return array before return an invalid ressource.

I currently check with invalid user in my test system to report and fix .

[Shnoulle]

I found this on Google: https://php.watch/versions/8.1/LDAP-resource @Shnoulle

See here : https://github.com/Dennis1993/LimeSurvey/blob/91006af1e59f8338726dab68cdb8da2915a6372e/application/core/plugins/AuthLDAP/AuthLDAP.php#L337

We return an array if ldap_connect return false.

[Shnoulle]

PS : see this simple code

        if ($ldapconn === false) {
            $this->setAuthFailure($ldapconn['errorCode'], gT($ldapconn['errorMessage']));

if $ldapconn === false then $ldapconn['errorCode'] is not set …

[andreas-bulling]

I checked out the latest version from git but the problem isn't fixed for me with PHP 8.1. I still see the same error message "Cannot use object of type LDAP\Connection as array "

The error is in line 482:

if (isset($ldapconn['errorCode'])) {

EDIT: This error also occurs in other places. I think this needs a much more fundamental fix. The problem is that the type of $ldapconn is not unique, it is "misused" as an array - sometimes but not always. Part of the code expects an array, other parts don't.

For example, if I remove the first error by adding is_array($ldapconn), then I see another error in line 233

$oEvent->set('errorMessageBody', $ldapconn['errorMessage']);

I think this framework should be used instead:
https://www.php.net/manual/de/function.ldap-error.php

[andreas-bulling]

I fixed those errors and created a pull request:
#2684

Now I see the following error message:
Credentials are valid but we failed to create a user

mail and full name properties have been set in the plugin settings

[Shnoulle]

EDIT: This error also occurs in other places. I think this needs a much more fundamental fix. The problem is that the type of $ldapconn is not unique, it is "misused" as an array - sometimes but not always. Part of the code expects an array, other parts don't.

$ldapconn is array when error. Let me fix it again

[andreas-bulling]

Fixed by #2684 and #2685