Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #18102: Export Duplicate entries in the Excel Form #2673

Merged

Conversation

Shnoulle
Copy link
Collaborator

Dev: replace rewriteLimitOffsetSql for SQL SERVER up to 11
Dev: inspiration by Yii2

Dev: replace rewriteLimitOffsetSql for SQL SERVER up to 11
Dev: inspiration by Yii2
Copy link
Collaborator

@gabrieljenik gabrieljenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code structure seems OK.
Haven't tested it

@Shnoulle
Copy link
Collaborator Author

Code structure seems OK. Haven't tested it

Super hard to test … and code structure for microsoft SQL server ;)

@Shnoulle Shnoulle added Tested OK This PR has been tested by QA and works as expected Code review done Version checked for code issue without testing Technical Technical update / enhancement labels Oct 24, 2022
@Shnoulle
Copy link
Collaborator Author

Tested by reporter

Alternative more easy to test : https://bugs.limesurvey.org/view.php?id=18420 see what happen with this file.

@olleharstedt
Copy link
Contributor

Hmm, shouldn't this also be a patch for Yii 1.1?

@Shnoulle
Copy link
Collaborator Author

Yes, too … but must find a good way to reproduce, i have to report : it take time …
And waiting for merge in Yii1 can be longer. Il like

@olleharstedt olleharstedt merged commit 5f7030c into LimeSurvey:master Oct 24, 2022
@olleharstedt
Copy link
Contributor

Maybe you can create a thread on their forum, @Shnoulle ?

@Shnoulle
Copy link
Collaborator Author

i have to report : it take time …

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code review done Version checked for code issue without testing Technical Technical update / enhancement Tested OK This PR has been tested by QA and works as expected
Projects
None yet
3 participants