Fixed issue #18543: Question Type "Array (texts)" crashes when in combination with "array filter", "Array filter style": disabled and "show totals"

[gabrieljenik]

There were two problems:

1. When sumTable set the total of the rows and columns, the jquery selector for updating the input field was based only on the "disabled" condition. It did not check that it was the input corresponding to the total, for example by class or id.

Under normal conditions, the only one disabled is the total, but when you use "Array Filter Style" = "disabled" there are more fields disabled, which created confusions.

It also created loops.
After the total field is updated, some events are triggered and the checkconditions is executed again.
When that was triggered for the "disabled" filtered fields, it created a loop.

2. In the "relevance:on", it removed the disabled from all the entries in the row, including the total one, which should always be disabled.

The ticket error was caused by point 1, but without fixing point 2 it would still look bad, so I fixed both.

[Shnoulle]

Can you check with .answer-item input selector ?

[Shnoulle]

👍

Not tested : think must test array_filter with multiple choice, ranking etc …

[Shnoulle]

Seems test broken with multiple and radio

input stay disabled
limesurvey_survey_139438.lss.txt

[Shnoulle]

Seems test broken with multiple and radio

because event.target == <tag class="answer-item">

            if($(event.target).hasClass("answer-item")) {
                $(event.target).find('input').each(function(itrt, item ){
                    $(item).prop("disabled", false );
                });
            } else {
                $(event.target).find('.answer-item input').each(function(itrt, item ){
                    $(item).prop("disabled", false );
                });
            }

[gabrieljenik]

What do you think now?

[Shnoulle]

Code review done,
To be tested again

[Shnoulle]

Firefox, asset resetted (i validate it's this file) : recursion again :(
limesurvey_survey_Filter4.lss.txt

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[Shnoulle]

Argl debug=0 issue ?

[Shnoulle]

OK !
Tested OK

[gabrieljenik]

OK ! Tested OK

OK, the issue was the minified file was missing.

[Shnoulle]

OK ! Tested OK

OK, the issue was the minified file was missing.

debug=0 issue … didn't happen if debug set … ouf …

[twilligls]

works for me as well!