Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #18507: {ANSWERTABLE} not working in basic admin notification #2794

Merged
merged 1 commit into from Jan 5, 2023
Merged

Fixed issue #18507: {ANSWERTABLE} not working in basic admin notification #2794

merged 1 commit into from Jan 5, 2023

Conversation

gabrieljenik
Copy link
Collaborator

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Shnoulle
Shnoulle requested changes Dec 15, 2022
View reviewed changes
Copy link
Collaborator

@Shnoulle Shnoulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need improvement … do action one time only and not for every emails …

application/helpers/frontend_helper.php Show resolved Hide resolved
Shnoulle
Shnoulle approved these changes Dec 19, 2022
View reviewed changes
Copy link
Collaborator

@Shnoulle Shnoulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original code is really badly optimized …

@Shnoulle Shnoulle added Code review done Version checked for code issue without testing and removed Needs update by author Needs code review labels Dec 19, 2022
@Shnoulle
Copy link
Collaborator

https://bugs.limesurvey.org/view.php?id=18563

@gabrieljenik gabrieljenik added Tested OK This PR has been tested by QA and works as expected and removed Needs testing labels Dec 22, 2022
@olleharstedt olleharstedt merged commit d2c6b95 into master Jan 5, 2023
@c-schmitz c-schmitz deleted the bug/18507--ANSWERTABLE-not-working-in-basic-admin-notification branch June 20, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shnoulle Shnoulle Shnoulle approved these changes

Assignees
No one assigned
Labels
Code review done Version checked for code issue without testing Tested OK This PR has been tested by QA and works as expected
Projects
None yet
Milestone
No milestone
4 participants
@gabrieljenik @Shnoulle @olleharstedt @lapiudevgit