Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #18542: Plugins: PasswordRequirement plugin is not working properly #2823

Merged
merged 1 commit into from Jan 4, 2023
Merged

Fixed issue #18542: Plugins: PasswordRequirement plugin is not working properly #2823

merged 1 commit into from Jan 4, 2023

Conversation

gabrieljenik
Copy link
Collaborator

ctype_lower doesn't work good when having numbers.

@sonarcloud
Copy link

sonarcloud bot commented Dec 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Shnoulle
Shnoulle approved these changes Jan 2, 2023
View reviewed changes
Copy link
Collaborator

@Shnoulle Shnoulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Shnoulle Shnoulle added Code review done Version checked for code issue without testing minor impact Minor impact update / enhancement and removed Needs code review labels Jan 2, 2023
@gabrieljenik gabrieljenik added Tested OK This PR has been tested by QA and works as expected and removed Needs testing labels Jan 3, 2023
@olleharstedt olleharstedt merged commit 1c2b830 into master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shnoulle Shnoulle Shnoulle approved these changes

Assignees
No one assigned
Labels
Code review done Version checked for code issue without testing minor impact Minor impact update / enhancement Tested OK This PR has been tested by QA and works as expected
Projects
None yet
Milestone
No milestone
4 participants
@gabrieljenik @Shnoulle @olleharstedt @lapiudevgit