Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #18542: Plugins: PasswordRequirement plugin is not working properly #2847

Merged
merged 3 commits into from Feb 8, 2023
Merged

Fixed issue #18542: Plugins: PasswordRequirement plugin is not working properly #2847

merged 3 commits into from Feb 8, 2023

Conversation

gabrieljenik
Copy link
Collaborator

Found bug while creating automated test on issue 18370

Shnoulle
Shnoulle approved these changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@Shnoulle Shnoulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Shnoulle Shnoulle added Code review done Version checked for code issue without testing and removed Needs code review labels Jan 17, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@gabrieljenik gabrieljenik added Tested OK This PR has been tested by QA and works as expected and removed Needs testing labels Jan 19, 2023
@olleharstedt
Copy link
Contributor

✘ Create user expired

Hmm, this test was fixed or?

@gabrieljenik
Copy link
Collaborator Author

✘ Create user expired

Hmm, this test was fixed or?

It was!

I will merge master again and check

@gabrieljenik gabrieljenik mentioned this pull request Jan 26, 2023
Merged
@gabrieljenik
Copy link
Collaborator Author

It is very strange.
For commit 558396, we have the following.

image

For push failed, but went good for pull?
Why do we have these 2 different push and pull? What do they mean?

@gabrieljenik
Copy link
Collaborator Author

Again. Pull is faiing, but push is good.
What's the difference in between them?

@gabrieljenik
Copy link
Collaborator Author

Test are green now. We should merge this first, then #2848

@olleharstedt olleharstedt merged commit d5bc7d2 into master Feb 8, 2023
@c-schmitz c-schmitz deleted the bug/18542_PasswordRequirement_plugin_is_not_working_properly branch June 20, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shnoulle Shnoulle Shnoulle approved these changes

Assignees
No one assigned
Labels
Code review done Version checked for code issue without testing Needs update by author Tested OK This PR has been tested by QA and works as expected
Projects
None yet
Milestone
No milestone
4 participants
@gabrieljenik @olleharstedt @Shnoulle @lapiudevgit