Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue #18548: Quick add function "Code ; Title" doesn't work. #2892

Merged

Conversation

gabrieljenik
Copy link
Collaborator

Message in quick add popup added. “Please recall to use the save button after applying the changes”

Message in quick add popup added. “Please recall to use the save button after applying the changes”
Copy link
Collaborator

@Shnoulle Shnoulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't really fix the issue.

@Shnoulle Shnoulle added Code review done Version checked for code issue without testing and removed Needs code review labels Feb 9, 2023
@gabrieljenik gabrieljenik changed the title 18548: Quick add function "Code ; Title" doesn't work. Fixed Issue #18548: Quick add function "Code ; Title" doesn't work. Feb 9, 2023
@gabrieljenik gabrieljenik added Tested OK This PR has been tested by QA and works as expected and removed Needs testing labels Feb 15, 2023
@@ -15,7 +15,7 @@

<div class="modal-body">
<p>
{{ gT('Enter one label per line. You can provide a code by separating code and label text with a semicolon or tab. For multilingual surveys you add the translation(s) on the same line separated with a semicolon or tab.') }}
{{ gT('Enter one label per line. You can provide a code by separating code and label text with a semicolon or tab. For multilingual surveys you add the translation(s) on the same line separated with a semicolon or tab. Please recall to use the save button after applying the changes.') }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Please remember"?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the UX severely broken if you have to remind people of using the save-button...?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #2906

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Please remember"?

Done.

Isn't the UX severely broken if you have to remind people of using the save-button...?

Well, that's another LONG discussion :) This is just for trying to make things less worst :)
Honestly. I don;t think it is a huge UI issue.
I don't believe is something that happens very often.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly. I don;t think it is a huge UI issue.

👍

I don't believe is something that happens very often.

It happen very often, but since it's not an huge issue nobody report it :).

@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@olleharstedt olleharstedt merged commit 5bf664c into master Feb 17, 2023
@c-schmitz c-schmitz deleted the bug/18548-quick-add-function-Code-Title-does-not-work branch June 20, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code review done Version checked for code issue without testing Tested OK This PR has been tested by QA and works as expected
Projects
None yet
4 participants