Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #18635: Export single response can goes to a white page #2923

Merged
merged 3 commits into from May 5, 2023
Merged

Fixed issue #18635: Export single response can goes to a white page #2923

merged 3 commits into from May 5, 2023

Conversation

Shnoulle
Copy link
Collaborator

Dev: remove session usage for export response in massive action widget
Dev: send it via POST and clean up some $_GET value

@Shnoulle
Fixed issue #18635: Export single response can goes to a white page
98cf04b 
Dev: remove session usage for export response in massive action widget
Dev: send it via POST and clean up some $_GET value
@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

gabrieljenik
gabrieljenik approved these changes Feb 16, 2023
View reviewed changes
Copy link
Collaborator

@gabrieljenik gabrieljenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code structure is OK. Haven't tested

@gabrieljenik gabrieljenik added Code review done Version checked for code issue without testing and removed Needs code review labels Feb 16, 2023
@Shnoulle Shnoulle changed the base branch from master to 5.x April 27, 2023 13:12
@Shnoulle Shnoulle mentioned this pull request Apr 27, 2023
Merged
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Shnoulle Shnoulle requested a review from tiborpacalat May 4, 2023 14:26
@tiborpacalat tiborpacalat added Tested OK This PR has been tested by QA and works as expected and removed Needs testing In Testing labels May 5, 2023
@tiborpacalat tiborpacalat merged commit 28f4add into 5.x May 5, 2023
8 of 10 checks passed
@tiborpacalat tiborpacalat deleted the bug/18635_exportsinglewhite branch May 5, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieljenik gabrieljenik gabrieljenik approved these changes

@tiborpacalat tiborpacalat Awaiting requested review from tiborpacalat

Assignees
No one assigned
Labels
Code review done Version checked for code issue without testing Tested OK This PR has been tested by QA and works as expected
Projects
None yet
Milestone
No milestone
3 participants
@Shnoulle @gabrieljenik @tiborpacalat