Fixed issue #18630: Survey list showing wrong icon for surveys. #2960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Time adjust considered for icon generation.
Shnoulle
reviewed
Mar 2, 2023
Porting stuff from getState()
Shnoulle
reviewed
Mar 2, 2023
Shnoulle
added
Code review done
|
SonarCloud Quality Gate failed. |
gabrieljenik
added
Tested OK
c-schmitz
deleted the
bug/18630-survey-list-showing-wrong-icon-for-surveys-basic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The icon was failing only when time adjust was NOT zero, as then sExpired was null and sNow was todays, but adjusted.
When that happened: oStop was set to now and sNow was set to Now but adjusted. That made the bExpired to be true.
Created tests.
Did a small change to fix the situation, and avoid using the "sometimes-wrongly-calculated" value.
These needs to be reviewed a bit more as there is a lot of duplicated code.
Started a reorganization draft but will pick up later: #2957
So far, with this I think is a good starter.