Fixed issue #9591: Sometimes date_max / date_min validations for date/t... #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/time questions doesn't allow to use the maximum date expected. - Reformat expression held into date_max / date_min into "Y-m-d H:i" format, so comparison can be done among equals format.
|
Will cause problems if someone enters a date > 2038 in min/max date. But at the end of unix time, the world wil probably seize to exist anyway. ;) Thanks for the fix! |
mfaber
added a commit
that referenced
this pull request
Mar 31, 2015
Fixed issue #9591: Sometimes date_max / date_min validations for date/t...
|
@gabrieljenik Could you please also add to 2.06 branch? Thanks! |
|
One upside that I noticed is that now US users will be able to enter min_date / max_date in natural language. |
|
Yes, all the date formats correctly parsed by strtotime will work (YYYY-MM-DD, YYYY/MM/DD, DD.MM.YYYY, MM/DD/YYYY, DD-MM-YYYY).. :) |
|
PR for v2.06: #299 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ime questions doesn't allow to use the maximum date expected.