Fixed issue #17883: QueXML formatting cannot be changed (master) #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using Export to SAV
…on showing name of available options instead of "Rank #"
gabrieljenik
approved these changes
Apr 10, 2023
|
I've just rebased to 6.0.0 and needed to make some changes. I have tested this now on 6.0.0 |
gabrieljenik
added
Tested OK
olleharstedt
requested changes
Apr 12, 2023
| @@ -185,6 +185,15 @@ public function actionView($surveyid, $printableexport = false) | |||
|
|
|||
| $quexmlpdf = new quexmlpdf(); | |||
|
|
|||
| //apply settings stored at last output | |||
There was a problem hiding this comment.
Code duplication? Looks like the same snippet as below?
There was a problem hiding this comment.
Yes, could be a routine of quexml?
applyGlobalSettings() ?
There was a problem hiding this comment.
thanks for the suggestion I've done that
| /** | ||
| * Apply global settings from LimeSurvey application | ||
| * | ||
| * @access public |
There was a problem hiding this comment.
This annotation is not needed, it's already set to public with the keyword. :)
| * | ||
| * @access public | ||
| */ | ||
| public function applyGlobalSettings() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #17883: : QueXML formatting cannot be changed (master)
Dev: This is a similar fix for master that was merged in to 3.x-LTS (see #2561 )