Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #18765: Answers are not populated correct in array dual scale after clicking "Back" #3061

Merged
merged 3 commits into from
May 9, 2023
Merged

Fixed issue #18765: Answers are not populated correct in array dual scale after clicking "Back" #3061

merged 3 commits into from
May 9, 2023

Conversation

gabrieljenik
Copy link
Collaborator

No description provided.

Shnoulle
Shnoulle requested changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@Shnoulle Shnoulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=== ''

0 == '' == false

application/core/QuestionTypes/ArrayMultiscale/RenderArrayMultiscale.php Outdated Show resolved Hide resolved
application/core/QuestionTypes/ArrayMultiscale/RenderArrayMultiscale.php Outdated Show resolved Hide resolved
application/core/QuestionTypes/ArrayMultiscale/RenderArrayMultiscale.php Outdated Show resolved Hide resolved
@tiborpacalat
Copy link
Collaborator

I tested this and it works as expected.

Testing protocol:

  1. Import lss file
  2. Preview run
  3. Fill in dual array question
  4. Click next
  5. Click back

@tiborpacalat tiborpacalat added Tested OK This PR has been tested by QA and works as expected and removed Needs testing labels Apr 20, 2023
@Shnoulle
Copy link
Collaborator

OK, loose compare string with string

Shnoulle
Shnoulle reviewed May 3, 2023
View reviewed changes
Copy link
Collaborator

@Shnoulle Shnoulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 2 value for no answer null or ===''

Usage of is_empty make it complex to understand. And clearly : we need to check this 2 values.

application/core/QuestionTypes/ArrayMultiscale/RenderArrayMultiscale.php Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@gabrieljenik gabrieljenik added Code review done Version checked for code issue without testing and removed Needs code review labels May 8, 2023
@tiborpacalat tiborpacalat merged commit 59c4e84 into master May 9, 2023
17 checks passed
@tiborpacalat tiborpacalat deleted the bug/18765--Answers-are-not-populated-correct-in-array-dual-scale-after-clicking-Back branch May 9, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shnoulle Shnoulle Shnoulle approved these changes

@olleharstedt olleharstedt Awaiting requested review from olleharstedt

Assignees
No one assigned
Labels
Code review done Version checked for code issue without testing Tested OK This PR has been tested by QA and works as expected
Projects
None yet
Milestone
No milestone
5 participants
@gabrieljenik @tiborpacalat @Shnoulle @olleharstedt @lapiudevgit