New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue # Fixed issue #18639: Token browse can be unusable with lot of data in attribute #3082
Conversation
…ot of data in attribute Dev: longtext formatter + scss Dev: TODO css
@ptelu : how to construct the css via the scss ? Or where ad this scss fix ? |
Thank you, Seems OK or need another class ? |
SonarCloud Quality Gate failed. |
@ptelu just to know if there are a reason to remove I add it again ? Maybe need to create a new class and fix from scratch ? |
i think its fine yes, we removed it mostly because everything was based on the table class. But i agree that gridviews should have a distinct name. We didn't get to moving the remnants remnants out of adminbasics_temporary. They have their own component folder in the theme "assets/admin_themes/Sea_Green/tables". I would rename/readd the grid class to "ls-gridview" then it would fit with our custom naming as well as with the controller. For this fix i think it is fine if you add the class again, we can add another task to rename/readd and move the code to the right folder. |
See othe scss part : https://github.com/LimeSurvey/LimeSurvey/blob/master/assets/admin_themes/adminbasics_temporary/grid.scss Some seems great , unsure on some other |
Did you see : seems BS5 have fixed the issue with tooltip too. |
Dev: longtext formatter + scss
Dev: TODO css