Fixed issue 18459: When filtering the survey list by a parent survey group, surveys assigned to a child survey group are not listed #3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…group, surveys assigned to a child survey group are not listed
…group, surveys assigned to a child survey group are not listed
Shnoulle
reviewed
May 18, 2023
Shnoulle
approved these changes
May 19, 2023
Shnoulle
added
Code review done
Shnoulle
reviewed
May 22, 2023
…group, surveys assigned to a child survey group are not listed
Shnoulle
added
the
Test failed
|
I add the Test failed for the quick filter (SQL issue). Unsure on the id=X, let wait for Mazi advice here. |
…group, surveys assigned to a child survey group are not listed - Modified the Survey Group list to behave the same
gabrieljenik
removed
the
Test failed
|
Ready for re-reviewal... |
Shnoulle
approved these changes
May 24, 2023
application/extensions/admin/survey/ListSurveysWidget/ListSurveysWidget.php
Show resolved
Hide resolved
…group, surveys assigned to a child survey group are not listed - Fixed 'Any group' search
…-by-a-parent-survey-group--surveys-assigned-to-a-child-survey-group-are-not-listed
|
SonarCloud Quality Gate failed. |
gabrieljenik
added
Tested OK
tiborpacalat
deleted the
bug/18459--When-filtering-the-survey-list-by-a-parent-survey-group--surveys-assigned-to-a-child-survey-group-are-not-listed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.