Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleared old bs switch files #3189

Merged
merged 4 commits into from Jun 12, 2023
Merged

Conversation

jack-han-115
Copy link
Contributor

@jack-han-115 jack-han-115 commented Jun 5, 2023

Fixed issue #: CR-307
New feature #:
Related to: previous PR

@olleharstedt
Copy link
Collaborator

Please see comments. :) Else looks good. 👍

@olleharstedt olleharstedt added Needs testing Code review done Version checked for code issue without testing labels Jun 6, 2023
@olleharstedt
Copy link
Collaborator

OK to me! Didn't test anything tho. Which Jira task is this connected to again? Please include it in the PR title so it's easy to find. 😵‍💫

@jack-han-115
Copy link
Contributor Author

jack-han-115 commented Jun 6, 2023

I added a related Jira ticket link.
btw, I use the ticket number as the prefix of the PR title.

@olleharstedt
Copy link
Collaborator

Oh yeah, the branch name, great. 👍

@jack-han-115 jack-han-115 merged commit 7e67e74 into develop Jun 12, 2023
11 of 15 checks passed
@jack-han-115 jack-han-115 deleted the cr-307/old-bootstrap-clear-3 branch June 12, 2023 10:19
@sonarcloud
Copy link

sonarcloud bot commented Jun 12, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@olleharstedt
Copy link
Collaborator

There was a tiny warning regarding PHP style here when you merged @jack-han-115 . I fixed it already, so no worries, but better to be fixed before merge in the future. :)

FILE: ...k/LimeSurvey/LimeSurvey/application/controllers/admin/Tokens.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 2760 | ERROR | [x] The first expression of a multi-line control
      |       |     structure must be on the line after the opening
      |       |     parenthesis
 2761 | ERROR | [x] The closing parenthesis of a multi-line control
      |       |     structure must be on the line after the last
      |       |     expression

@jack-han-115
Copy link
Contributor Author

ok, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code review done Version checked for code issue without testing Needs testing
Projects
None yet
2 participants