Fixed issue #18401: Unable to use checkdate function if debug set #3214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checkdate wrap added.
checkdate function result test added.
… set" This reverts commit 4c677ff.
checkdate wrap added.
Shnoulle
approved these changes
Jun 12, 2023
|
Pnding of hooking new function to expression manager |
|
SonarCloud Quality Gate failed. |
|
Now should be Ok |
Shnoulle
approved these changes
Jun 13, 2023
| public function testYearCheck() | ||
| { | ||
| $check_string = exprmgr_checkdate(06, 07, 'Twenty Twenty-three'); | ||
| $this->assertFalse($check_string, 'Unexpected evaluation result, the year parameter should not be a string.'); |
| $this->assertFalse($check_string, 'Unexpected evaluation result, the year parameter should not be a string.'); | ||
|
|
||
| $check_numeric = exprmgr_checkdate(06, 07, '2023'); | ||
| $this->assertTrue($check_numeric, 'Unexpected evaluation result, the year parameter can be a numeric value.'); |
| $this->assertTrue($check_numeric, 'Unexpected evaluation result, the year parameter can be a numeric value.'); | ||
|
|
||
| $check_int = exprmgr_checkdate(06, 07, 2023); | ||
| $this->assertTrue($check_int, 'Unexpected evaluation result, the year parameter can be an integer.'); |
Shnoulle
added
Code review done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.