Fixed issue #18823: STATA Export fails with certain question types #3220
Conversation
Survey deleted to avoid error on another test.
Loading a different survey.
|
SonarCloud Quality Gate failed. |
|
|
||
| public static function tearDownAfterClass(): void | ||
| { | ||
| self::$testSurvey->delete(); |
There was a problem hiding this comment.
If i don't make error , it's already in parent
There was a problem hiding this comment.
Somehow, it wasn't working for us, so added it as a reassurance
There was a problem hiding this comment.
Strange :
LimeSurvey/tests/TestBaseClass.php
Line 133 in 804319a
There was a problem hiding this comment.
Have just updated it. Let me see how it goes now.
There was a problem hiding this comment.
Hope we don't leave the survey because it don't break Test.
Remind : when test abort/broke : survey was not deleted. Maybe we need to add a Dev solution for this ?
Shnoulle
added
Code review done
|
Just remove the 3 private var and i mrege https://sonarcloud.io/project/issues?id=LimeSurvey_LimeSurvey&pullRequest=3220&resolved=false&types=CODE_SMELL (after check the cancelled 7.4 push) |
|
All green |
Shnoulle
deleted the
bug/18823-STATA-export-fails-with-certain-question-types
branch
Very basic sanity test added