Fixed issue 18821: Public url is not used for SURVEYURL

[twilligls]

Fixed issue #:
New feature #:
Dev:

[Shnoulle]

Another solution can be add a LSYii_Application->getBaseUrl ?

[twilligls]

Another solution can be add a LSYii_Application->getBaseUrl ?

Yes, maybe good idea

[Shnoulle]

Put this on dev mantis maybe, we need to review App->getController()->getAbsoluteUrl()

[twilligls]

Another solution can be add a LSYii_Application->getBaseUrl ?

Doesn't work, because you would override the baseUrl all the time with configured publicurl, even when you don't need it.

[twilligls]

Put this on dev mantis maybe, we need to review App->getController()->getAbsoluteUrl()

I don't understand

[Shnoulle]

Put this on dev mantis maybe, we need to review App->getController()->getAbsoluteUrl()

I don't understand

Just create a Development mantis issue : https://bugs.limesurvey.org/bug_report_page.php

Another solution can be add a LSYii_Application->getBaseUrl ?

Doesn't work, because you would override the baseUrl all the time with configured publicurl, even when you don't need it.

👍

Maybe a new function then ? I think we need it for API too.

[gabrieljenik]

Some comments, maybe for the DEV branch:

• I agree we need a method on the app but only for the createPublicUrl
  • Make new method based on LSYiiController::createAbsoluteUrl()
  • Make LSYiiController::createAbsoluteUrl() to call the new app method.
  • Probably rename the LSYiiController::createAbsoluteUrl() to LSYiiController::createPublicUrl()

[gabrieljenik]

I don't like to call a controller from a model, but if no code reorg is to be done, I don't see any other way

[twilligls]

Yeah it's hard to draw the line between fixing a bug or refactor a lot of old code

[gabrieljenik]

Maybe you can just move the code to a helper?
Maybe now is a good time to create App::createPublicUrl() ?

[twilligls]

ok, you convinced me now :)

[twilligls]

Please check my latest commit

[Shnoulle]

I really like it !